baggage labels processor #2994
baggage labels processor #2994
Conversation
as-polyakov
commented
Mar 5, 2021
as-polyakov
commented
- a strowman implementation of baggage labels processor
- It is an implementation for MetricsProcessor #1810. Based on introducing view #2956 and labels processor #2964 and whole idea is sketched in this PR introduction of View and first version of LabelsProessor #2800
as-polyakov
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
| @Override | ||
| public Labels onLabelsBound(Context ctx, Labels labels) { | ||
| LabelsBuilder labelsBuilder = labels.toBuilder(); | ||
| baggageMetricsLabelsExtractor.fromBaggage(Baggage.fromContext(ctx)).forEach(labelsBuilder::put); |
There was a problem hiding this comment.
do we think this would want to be more opt-in as to which baggage labels are applied, rather than blindly applying all of them?
|
Hey @as-polyakov, any plans to get back to this PR? :) |
With the rewrite of metrics underway, I'm not sure working on this PR would be worth the time at this point. |
So shall we close it then? 🤔 |
Let's give @as-polyakov a couple days to respond. :) |
|
Hey folks, I am ok to close it. We have done our implementation and will be happy to contribute it back but given the upcoming rewrite I would rather do it in a new framework. Thank you! |
